Closed 0b5vr closed 6 months ago
Ready to merge!
We are going to bump the major since the breaking change occurs.
日本語で恐縮ですが、NodeMaterialを継承したマテリアルのコードを読む上で、NodeMaterialの動作の流れ(r164現在のもの)を以下のページにまとめてあります。レビューの際にご活用ください。
The rendering result differs when there is no texture and only a normal map.
examples/feature-test
webgpu-feature-test
Perhaps MToonMaterial was wrong?
const useUvInFrag =
...
this.uvAnimationMaskTexture !== null ||
this.normalMap !== null;
The rendering result differs when there is no texture and only a normal map.
It seems to be, yes! The blue ball in the example should have bumps on the surface since the normal map is assigned. I will fix this in another PR.
If possible, please incorporate this change. https://github.com/pixiv/three-vrm/commit/25cc2ba3f40c0f80d7da4a51a8e4cd84dc0a79ab
Resolved conflict with dev-v3
, it's now ready to build using esbuild.
I don't have to explicitly specify three/addons/nodes/Nodes.js
, esbuild seems to handle this by only specifying three
.
If possible, please incorporate this change. 25cc2ba
yes I have to indeed
If possible, please incorporate this change. 25cc2ba
yes I have to indeed
done @ https://github.com/pixiv/three-vrm/pull/1384/commits/36f064fb7653920ec4ff3bf453ac478ba08432dc
MToonNodeMaterial
is gonna be compatible only with r161 or higher.
I added a warning if the user attempts to use this in r160 or before.
https://github.com/pixiv/three-vrm/pull/1384/commits/afe9143d2054097c1b99aae876a77d4bbe58c38c
This PR supports WebGPURenderer by adding
MToonNodeMaterial
, which is a NodeMaterial port ofMToonMaterial
.After the change is published, you can use three-vrm on WebGPU by using
MToonNodeMaterialLoaderPlugin
. To use the loader, specify the loader in the option ofVRMLoaderPlugin
. See thewebgpu-dnd.html
example for details.BREAKING
gltf.userData.vrmMToonMaterials
might have materials other thanMToonMaterial
(namely,MToonNodeMaterial
in this case).MToonNodeMaterial
is almost identical toMToonMaterial
.TODOs
three-vrm-material-mtoon
importsthree/addons/nodes/Nodes.js
, the initial module loading time became longer when you are using certain CDNs like unpkg. We are currently seeking for a workaround.@types/three
are patched bypatch-package
three-ts-types
side before we ship thisType of property 'cache' circularly references itself ...
error (TS2615) occurs