pixiv / webrtc

This is a fork of WebRTC made by pixiv Inc.
https://github.com/pixiv/webrtc/blob/branch-heads/pixiv-m78/README.pixiv.md
BSD 3-Clause "New" or "Revised" License
112 stars 35 forks source link

EXC_BAD_ACCESS on CritScope::CritScope #21

Open ragian opened 3 years ago

ragian commented 3 years ago

Hi, I want to report a "bug".

Develop environment: iOS: 14.5 Devices: iPhone 6s, iPhone SE, iPad Pro Xcode: 12.5 (12E262) macOS: 11.2.1 (20D74) Fat Framework builded: from the banch branch-heads/pixiv-m78

Some time to time I get an (but very often):

EXC_BAD_ACCESS

on

CritScope::CritScope(const CriticalSection* cs) : cs_(cs) {
  cs_->Enter();
}

of the file

critical_section.cc

akihikodaki commented 3 years ago

Hi,

I suggest to use the latest release (https://github.com/pixiv/webrtc/releases/tag/87.0.4280.142-pixiv0).

Also, a crash located at critical_section.cc usually implies some use of rtc::CritScope is wrong and the implementation of rtc::CritScope itself is fine. Please provide a full stack trace for better understanding of the problem.