pixlsus / raw

raw.pixls.us website
4 stars 7 forks source link

archives #68

Closed LebedevRI closed 7 years ago

LebedevRI commented 7 years ago

Something needs to be done about archive upload.

patdavid commented 7 years ago

What needs to be addressed?

LebedevRI commented 7 years ago

Simple solution: add one more checkbox above "Choose file" saying something like "this file is a single raw image, not an archive" More complicated solution would be to additionally check mime type of newly uploaded file, and completely discard (as in, not even add to db) if it is tar/zip/rar/etc

paperdigits commented 7 years ago

Can we just request it be a raw file and not zipped in the instructional text, then throw an error if the user tries to upload an archive?

On June 5, 2017 11:52:36 AM PDT, Roman Lebedev notifications@github.com wrote:

Simple solution: add one more checkbox above "Choose file" saying something like "this file is a single raw image, not an archive" More complicated solution would be to additionally check mime type of newly uploaded file, and completely discard (as in, not even add to db) if it is tar/zip/rar/etc

-- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub: https://github.com/pixlsus/raw/issues/68#issuecomment-306272371

andabata commented 7 years ago

I think if we can use some js to block the most common archive formats, and unwanted fileformats (.png / .jpg). That would reduce 'wrong' uploads a lot.

andabata commented 7 years ago

We now can add unwanted fileextensions. This should solve .jpg, .png .zip .rar uploads.