pixolith / fabricjs-customise-controls-extension

Customise the Icon/Cursor/Action of the fabric.js controls
275 stars 100 forks source link

Some options don't render as they should #44

Closed SmboBeast closed 7 years ago

SmboBeast commented 7 years ago

Hi,

When not using custom icons, the code below doesn't actually render accordingly. No matter what, corner icons are squared and the default blue outline is rendered. Is the code below supposed to make all objects have black circles as their corners?

fabric.Object.prototype.customiseCornerIcons({ settings: { borderColor: 'black', cornerSize: 25, cornerShape: 'circle', cornerBackgroundColor: 'black', cornerPadding: 10, }, }, function() { canvas.renderAll(); });

MDSLKTR commented 7 years ago

Hey again,

I will have a look, could be the case that since no icon is selected the settings will just jump to default which is incorrect as you stated.

Regards, Simon

Am 05.06.2017 um 00:36 schrieb Sam B notifications@github.com:

Hi,

When not using custom icons, the code below doesn't actually render accordingly. No matter what, corner icons are squared and the default blue outline is rendered. Is the code below supposed to make all objects have black circles as their corners?

fabric.Object.prototype.customiseCornerIcons({ settings: { borderColor: 'black', cornerSize: 25, cornerShape: 'circle', cornerBackgroundColor: 'black', cornerPadding: 10, }, }, function() { canvas.renderAll(); });

— You are receiving this because you are subscribed to this thread. Reply to this email directly, view it on GitHub, or mute the thread.

MDSLKTR commented 7 years ago

Shoud be fixed in: https://github.com/pixolith/fabricjs-customise-controls-extension/releases/tag/0.3.2

SmboBeast commented 7 years ago

It works perfectly. I sent over some beer as a thank you. ;)