search

pixop / video-compare

Split screen video comparison tool using FFmpeg and SDL2
GNU General Public License v2.0
969 stars 44 forks source link

[Feature Request] yt-dlp integration #17

Closed couleurm closed 2 years ago

couleurm commented 2 years ago

I often get sent similar videos via the discord cdn (links to raw video files) and find myself downloading both of them with yt-dlp/aria2 before firing up video-compare to check the differences

Give yt-dlp a look if integrating it to video-compare sounds like a good idea to you

(ps: yes yt-dlp can download on many more sites than YouTube, including video files hosted on discord's cdn)

jonfryd commented 2 years ago

Hey @couleurm,

Thanks for the suggestion!

I think HTTP/HTTPS input as an alternative to files is a good idea. It's something I have a need for occasionally myself.

I'm quite busy these days, though, so I can't promise when I'll have the time to look into it.

jonfryd commented 2 years ago

Hey @couleurm,

I have just released version 20220915 which allows all supported FFmpeg protocols to be used in URLs (including HTTP(S) like you requested).

I hope it works for your use case!

couleurm commented 2 years ago

doing gods work! thanks a lot!

chrizilla commented 1 year ago

@jonfryd thanks so much for this enhancement!

Can you give a simple working example for how the syntax works ? Thanks again!

couleurm commented 1 year ago

I don't think there's any special syntax, instead of passing a filepath you pass an url, am I missing something?

chrizilla commented 1 year ago

@couleurm thank you! Didn't think it would be as easy as that, because the info in the link below was very overwhelming:

@jonfryd : « I have just released version 20220915 which allows all supported FFmpeg protocols to be used in URLs (including HTTP(S) like you requested). »

So does the URL have to point to a file (like https://www.server.com/path/video.mp4) or does it work in tandem with yt-dlp (and it's extractors) now, so that the video is extracted from the site and different formats can be compared to each other with the -f switch? I am asking because you featurerequested "yt-dlp integration" as per this issue.

couleurm commented 1 year ago

yt-dlp was not integrated, just raw urls like you mentionned

chrizilla commented 1 year ago

@couleurm : Thanks for explaining. The http download capability and the addition of "all supported FFmpeg protocols" (with which I am not too familiar) is certainly a big enhancement, but you initially suggested yt-dlp integration and yt-dlp is normally used for more difficult downloads than mere http-file-downloads, i.e. the youtube downloads you mentioned in your OP:

Give yt-dlp a look if integrating it to video-compare sounds like a good idea to you (ps: yes yt-dlp can download on many more sites than YouTube

So what got me a bit confused is that the issue was closed without really addressing your feature suggestion (at least as far as I can see) ?

yt-dlp integration would certainly be nice, but I suspect really difficult to integrate ?