search

pixop / video-compare

Split screen video comparison tool using FFmpeg and SDL2
GNU General Public License v2.0
889 stars 41 forks source link

chinese char in filename not rendered correctly #27

Open zbutfly opened 1 year ago

zbutfly commented 1 year ago

not a major bug, but it display some error code

jonfryd commented 1 year ago

Hey @zbutfly,

Yeah, I'm aware of that. The embedded font included in the executable is mostly restricted to the Latin character set. Please see: https://github.com/pixop/video-compare/issues/25#issuecomment-1252155183

If someone knows of an easy-to-read TTF-font with solid unicode support (including Chinese and Japanese characters) that we can use legally (i.e. no licensing issues!), then please let me know.

I'm keeping the issue open for now.

zbutfly commented 1 year ago

Hey @zbutfly,

Yeah, I'm aware of that. The embedded font included in the executable is mostly restricted to the Latin character set. Please see: #25 (comment)

If someone knows of an easy-to-read TTF-font with solid unicode support (including Chinese and Japanese characters) that we can legitimately use (i.e. no licensing issues!), then please let me know.

I'm keeping the issue open for now.

embedded font (especially jp/cn chars) will increase size of the executable file much! i don't know much about the implementation of video rendering But can it be implemented by a float layer over media with system or external font?

jonfryd commented 1 year ago

Yes, embedding a font with JP/CN support will likely increase the executable file size significantly, but I can't think of a better way which works seamlessly on Linux, Mac OS and Windows. I don't want to introduce new dependencies and/or new ways of rendering the overlaid text. Using SDL's TTF rendering library is the best and simplest option, I think.

To reduce the installed executable file size we can use UPX.