pixop / video-compare

Split screen video comparison tool using FFmpeg and SDL2
GNU General Public License v2.0
969 stars 44 forks source link

Problems with video files with ancient format. #63

Closed deckeys closed 6 months ago

deckeys commented 6 months ago

I have issues with some video files that are old. The last version that works with these old files without crashing is the 20210827-precompiled-build. I tested it on Windows 10 21H2. Video-compare seems to be starting and even the compare window shows up for a few milliseconds but closes itself immediately. It happens on different files, it is not only limited to the format I am sending as an example here (MPEG-4 Visual and AVC). I tried to change only the container of these files to mp4, but that didn't help, the compare window still closes itself.

So I have uploaded both files (.avi and .m4v) I tried to compare here: archive.org/download/6x-06-blood-pressure-aci-d

jonfryd commented 6 months ago

Thanks for the report.

I'm marking the issue as Windows-related for now, as I'm able to compare your uploaded files without any problems using the latest Brew build for macOS. The next step is to test on my Windows laptop.

jonfryd commented 6 months ago

I was able to reproduce the problems using the videos you uploaded in Windows 10. To me, it seems to be a bug in FFmpeg's image scaling library if the output width is not divisible by 8 (I could be wrong, though). The width of your videos is all 636.

Anyway, I've pushed a commit that resolves the issue. For now, you can work around the issue yourself by applying padding filters using a recent build, for example:

./video-compare --left-filters pad=640 --right-filters pad=640 [video1] [video2]

I'm closing this one.