search

pixunil / cinnamon-applet-system-monitor

An applet for Cinnamon which shows CPU, Memory and Swap usage, Disk and Network rates with graphs
http://cinnamon-spices.linuxmint.com/applets/view/198
GNU General Public License v2.0
15 stars 5 forks source link

Fixed some JSHint problems #3

Closed ham1 closed 9 years ago

ham1 commented 9 years ago

e.g. tabs to spaces, white space around if, for, while and opening function braces, added 0 to .5 etc. for clarity and added braces around some single line if, else and for body to improve readability and make it less likely to make mistakes if changing that code in future. Also corrected some spelling mistakes in metadata.

The diff doesn't look very good as I replaced tabs with 4 spaces (if you still prefer tabs I can put them back and try the PR again). A "git diff -w" works fairly well or side-by-side diff.

Thanks for the applet!

pixunil commented 9 years ago

Thanks for noticing the two spelling mistakes. I'm changing the indention as this is the default in Cinnamon and mentioned in the official style guide. Your other changes are only style, and I can't see improvements for readability with this.