piyokintv / hayasaka

0 stars 0 forks source link

エラーが10個までしかFile changedに表示されない #6

Open piyokintv opened 1 year ago

piyokintv commented 1 year ago

https://github.com/piyokintv/hayasaka/actions/runs/3684188117/jobs/6233622975

Run git diff --name-only origin/main HEAD -- '*.php' \
Error: Expected at least 1 space before "="; 0 found
Error: Expected at least 1 space after "="; 0 found
Error: Line indented incorrectly; expected 8 spaces, found 4
Error: Expected 1 space(s) after IF keyword; 0 found
Error: Expected 1 space(s) after closing parenthesis; found 0
Error: Newline required after opening brace
Error: Closing brace must be on a line by itself
Error: Expected 1 space after closing brace; 0 found
Error: Expected 1 space(s) after ELSE keyword; 0 found
Error: Newline required after opening brace
Error: Each PHP statement must be on a line by itself
Error: Closing brace must be on a line by itself
Error: Expected at least 1 space before "="; 0 found
Error: Expected at least 1 space after "="; 0 found
Error: Line indented incorrectly; expected 8 spaces, found 4
Error: Expected 1 space(s) after IF keyword; 0 found
Error: Expected 1 space(s) after closing parenthesis; found 0
Error: Newline required after opening brace
Error: Closing brace must be on a line by itself
Error: Expected 1 space after closing brace; 0 found
Error: Expected 1 space(s) after ELSE keyword; 0 found
Error: Newline required after opening brace
Error: Each PHP statement must be on a line by itself
Error: Closing brace must be on a line by itself
Error: Line indented incorrectly; expected 8 spaces, found [14](https://github.com/piyokintv/hayasaka/actions/runs/3684188117/jobs/6233622975#step:7:15)
Error: Expected 1 space(s) after IF keyword; 0 found
Error: Expected 1 space(s) after closing parenthesis; found 0
Error: Newline required after opening brace
Error: Closing brace must be on a line by itself
Error: Expected 1 space after closing brace; 0 found
Error: Expected 1 space(s) after ELSE keyword; 0 found
Error: Newline required after opening brace
Error: Each PHP statement must be on a line by itself
Error: Closing brace must be on a line by itself
Error: Process completed with exit code 1.

github com_piyokintv_hayasaka_pull_3_files (1)

piyokintv commented 1 year ago

10個までしか表示されないが、正しいコーディングスタイルに整形していくと、次々表示される UserController.phpを全て整形すると、User.phpのエラーが表示された(↑と比較)

https://github.com/piyokintv/hayasaka/actions/runs/3684328645/jobs/6233934698

Run git diff --name-only origin/main HEAD -- '*.php' \
Error: Expected at least 1 space before "="; 0 found
Error: Expected at least 1 space after "="; 0 found
Error: Line indented incorrectly; expected 8 spaces, found 4
Error: Expected 1 space(s) after IF keyword; 0 found
Error: Expected 1 space(s) after closing parenthesis; found 0
Error: Newline required after opening brace
Error: Closing brace must be on a line by itself
Error: Expected 1 space after closing brace; 0 found
Error: Expected 1 space(s) after ELSE keyword; 0 found
Error: Newline required after opening brace
Error: Each PHP statement must be on a line by itself
Error: Closing brace must be on a line by itself
Error: Line indented incorrectly; expected 8 spaces, found [14](https://github.com/piyokintv/hayasaka/actions/runs/3684328645/jobs/6233934698#step:7:15)
Error: Expected 1 space(s) after IF keyword; 0 found
Error: Expected 1 space(s) after closing parenthesis; found 0
Error: Newline required after opening brace
Error: Closing brace must be on a line by itself
Error: Expected 1 space after closing brace; 0 found
Error: Expected 1 space(s) after ELSE keyword; 0 found
Error: Newline required after opening brace
Error: Each PHP statement must be on a line by itself
Error: Closing brace must be on a line by itself
Error: Process completed with exit code 1.

github com_piyokintv_hayasaka_pull_3_files

piyokintv commented 1 year ago

エラー自体はプルリクに10個までしか表示されない。 表示されているエラーを解決すると、非表示だったエラーが表示される。

表示されているエラーを解決していき、「All checks have passed」になるまでやれば良さそう? 差分行のエラーを解決するという本題はクリアできるため一旦無視

piyokintv commented 1 year ago

reviewdogを使えば解決できそう?

https://github.com/reviewdog/reviewdog