piyushgarg-dev / piyushgargdev-nextjs

https://piyushgarg.dev

191 stars 1.27k forks source link

[Bug]: Either terminal buttons should work or removed #955

Open harshitrathor3 opened 1 year ago

harshitrathor3 commented 1 year ago

Describe the bug

The terminal contains buttons like an open application in Mac. Either the button should work or it should be removed.

To Reproduce

Go to Home Page
Scroll down to Terminal
See the buttons just below where Terminal is written

Expected behavior

I think it should be removed because there is no need for them there.

Screenshots/Videos

No response

Additional context

No response

Please checkmark the following checklist

[x] I make sure that similar issue is not opened

su-brat commented 1 year ago

Can be labelled with hacktoberfest

su-brat commented 1 year ago

On a second thought those buttons look good and give a feeling of a terminal

harshitrathor3 commented 1 year ago

The gap should also be removed from where the buttons were present so that "welcome to my website..........." line should come just below the top line of the terminal box.

961

apsinghdev commented 1 year ago

I think they are good to be there because they are for style purposes not functionality. if you have any strong reason to work on this then please let me know.