piyushgarg-dev / review-app

Frontend Review Management Application | https://youtu.be/JD3NQsB3TQI
https://review-app-five.vercel.app
GNU General Public License v3.0
193 stars 281 forks source link

[Bug]: Route Corrections and Code Refactoring for About and Landing Page #256

Open sohan9819 opened 1 year ago

sohan9819 commented 1 year ago

Describe the bug

The route for the home page and about page are currently like this about page : http://localhost:3000/templates/ebraj/about

Also there are components that are shared by about.tsx - (about page) and index.tsx - (landing or home page) currently and the entire landing page is imported from the pages\templates\ebraj\index.tsx.

To Reproduce

  1. Go to landing page - http://localhost:3000
  2. Click on about on navbar.
  3. See the route.
  4. Go to the file pages\index.tsx check the code.
  5. Also check the files index.tsx and about.tsx from folder pages\templates\ebraj

Expected behavior

The route for the home page and about page are expected to be like this about page : http://localhost:3000/about We can refactor code and make a folder layout in components folder and move all the shared components of about.tsx and index.tsx there . Also move the entire code of landing page from pages\templates\ebraj\index.tsx to pages\index.tsx

Screenshots/Videos

Current route Screenshot 2023-10-24 131724

Expected route image

Additional context

I am already working on this issue so please assign this issue to me šŸ˜Š.

Please checkmark the following checklist

github-actions[bot] commented 1 year ago

Hey @sohan9819 šŸ˜ƒ,

Thank you for raising an issue. Soon, the owner/maintainers will review it and offer feedback/suggestions. Meanwhile if you enjoy contributing to the project, please consider giving it a star ā­.