piyushgarg-dev / review-app

Frontend Review Management Application | https://youtu.be/JD3NQsB3TQI
https://review-app-five.vercel.app
GNU General Public License v3.0
188 stars 283 forks source link

docs: Updated contributing doc where env local had different domains #275

Closed ArshadChowdhury closed 10 months ago

ArshadChowdhury commented 10 months ago

What does this PR do?

Fixes # (issue)

Updated Contributing.md file where it had only one public domain now we have two so had to update the doc accordingly.

Requirement/Documentation

Type of change

How should this be tested?

Mandatory Tasks

Checklist

vercel[bot] commented 10 months ago

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
review-app ❌ Failed (Inspect) Oct 31, 2023 2:49pm
github-actions[bot] commented 10 months ago

Thank you for following the naming conventions! 🙏

hemantwasthere commented 10 months ago

Already resolved!

ArshadChowdhury commented 10 months ago

@hemantwasthere bro the doc is not updated according to new env domain.

the previous & current version here is this -

NEXT_PUBLIC_AWS_API_URL=http://localhost:8000/local NEXT_PUBLIC_APP_DASHBOARD_DOMAIN=app NEXT_PUBLIC_APP_DOMAIN=localhost:3000

the new version should be this (in this pr) -

NEXT_PUBLIC_AWS_API_URL= NEXT_PUBLIC_APP_DASHBOARD_DOMAIN= NEXT_PUBLIC_APP_PUBLIC_DOMAIN= NEXT_PUBLIC_APP_CUSTOM_DOMAIN=

ArshadChowdhury commented 10 months ago

Thank you very much, really appreciate it.