pj4533 / pn2ps

Convert PokerNow.club logs into PokerStars hand history format
MIT License
6 stars 5 forks source link

Hand ID must be integer to work with Poker Copilot #16

Closed albertborsos closed 4 years ago

albertborsos commented 4 years ago

I am started to use Poker Copilot on Mac OS, because HM3 is not available for mac and I do not want to switch between OS's.

It throws an error on import:

2020-06-07 13:54:55.085 SEVERE : [Hand Producer] Unable to parse /Users/aborsos/Downloads/hand-histories/pokercopilot_generated_202006071347484.txt line 1: For input string: "AA81C62F4EF14148B052F61B703D4A00"
2020-06-07 13:54:55.086 SEVERE : [Hand Producer] Error caught: java.lang.NumberFormatException: For input string: "AA81C62F4EF14148B052F61B703D4A00"

java.lang.NumberFormatException: For input string: "AA81C62F4EF14148B052F61B703D4A00"
    at java.lang.NumberFormatException.forInputString(NumberFormatException.java:65)

This is because your export looks like this:

PokerStars Hand #AA81C62F4EF14148B052F61B703D4A00: Hold'em No Limit ($10.00/$20.00 USD) - 2020/05/29 20:27:03 ET

And pokerstars's looks like this:

PokerStars Hand #214671151654:  Hold'em No Limit (50/100) - 2020/05/30 11:30:49 ET

So for hand ID pokerstars uses an integer.

Thanks :)

pj4533 commented 4 years ago

Yeah....PokerTracker doesn't care, so I was using a string. PokerNow has per table hand ids, so will cause duplicates unless I come up with a way to make unique ints. The easy way would be to use the timestamp, but if people multi table, it is possible to have collisions.

albertborsos commented 4 years ago

How about the timestamp concatenated with the hand id?

Btw the timestamps are in microseconds, so there is a little chance for duplicated gameIds.

-- starting hand #214 (dealer: "bobo @ 8FYaQEvG6B") -- | 2020-06-02T22:17:40.429Z | 159113626043676
albertborsos commented 4 years ago

I tried PokerTracker, but it created a new OS user account just for the postgreSQL :D Also I cannot import history files in the trial version, and this is the only feature i need :D

pj4533 commented 4 years ago

For now I am doing a MD5 of the dealer ID + the timestamp, and chopping and converting to 64bit int. Seems to work, but not 100% sure it is what I want. If you notice any dupes, lemme know.

Releasing 0.0.5 now.