Closed albertborsos closed 4 years ago
Yeah agreed, I noticed the same. Would be awesome to have those in the output. I think I just need to add it to the summary? Should be pretty easy...
I played some round on pokerstars to reverse engineer what you should generate:
*** SHOW DOWN ***
Stemko7 : shows [3c 2d] (two pair, Jacks and Threes)
bobosapp: mucks hand
Stemko7 collected 3024 from pot
*** SUMMARY ***
Total pot 3200 | Rake 176
Board [Jh 9s Js 3d 7d]
...
Seat 5: bobosapp (button) mucked [Qc Th]
Seat 6: Stemko7 (small blind) showed [3c 2d] and won (3024) with two pair, Jacks and Threes
I think instead of the username: mucks hand
you should add the same format as the line above. And also to the summary?
oh man! thats awesome, i was wondering if there was a 'mucked' verb used in the logs. I was using this to reverse engineer it: https://en.wikipedia.org/wiki/Hand_history but that doesn't include all cases. Can you grab a couple more logs for me?
Of course. Give me the use cases you need.
the primary cases I need to fix now are:
I think this is fixed in 0.0.3 - I’ll do a release later today. Please respond if it’s still broken after trying the new version.
Once I do the release later, please check this issue especially. I include the shown hands now, but not sure if I got the format exactly right. For example, I could see the cards in pokertracker when I replayed the hand, but not in the summary columns. Might be that’s just how the software works, or could be that it reads from some part of the log I didn’t get right. If you can check with holdem manager, that’d be great! As I said, 0.0.3 should be posted momentarily.
Awesome, works great in HM3.! Thanks!
Yes, you are using different format. In my compiled game log it looks like:
Seat 7: Áron (small blind) collected ($120.00) [Kd Ad]
based on the previous pokerstars log should look like:
Seat 7: Áron (small blind) showed [Kd Ad] and won ($120.00)
and there is a with high card A
but i think it is unnecessary beside that it is pretty complicated to translate hands into words.
Hmmm...not 100% sure the pokerstars log would look that way for a folded hand, where the winner ends up showing. Thats the case I need to see. I agree what you wrote is what it would look like for a hand that went to showdown though, and the description of the winning hand is included in the PokerNow log also, so its not hard. However PokerNow doesn't include the winning hand description if the showdown did not happen, regardless if the person shows. (which makes me think maybe PokerStars doesn't either?)
Do you happen to have a real PokerStars log for this case so we can compare?
I think the following scenario is not processed. Everyone folds on a raise, but then they showed their cards.
source:
result:
ps: Just updated the example to a simpler one.