Closed parasyte closed 2 years ago
This PR is big enough already. I'll do the inline assembler in another pass. For now, this is ready for wider testing. I'll squash and merge in a day or two if I don't hear any feedback suggesting against it.
All LGTM, the only suggestions I would have is to make the Memory viewer able to copy/paste but I know making it a full-fledged Memory Editor is in the plans. Other than that, maybe I would add access to the memory/binary dump not just from the Cheat search but the Debugger menu as well, maybe inside the memory viewer window, seems more logical that way.
Thanks @oddMLan. Those all sound like good things to include! Selection and clipboard support for the memory viewer is coming in another PR. I can add access to the dump dialog there too.
Editing memory is also in the game plan.
Followup to #5, these improvements are to the r4300i Commands window. Primary changes:
Some additional things I would like to do before merging:
Copying requires either selecting a range of lines or just always copy whatever is drawn to the screen. I would like to make it possible to select ranges larger than what can be shown in a single page. It's a bit of work.
The inline assembler would allow editing instructions. It could also make use of the line range selections.