pj64team / Project64-Legacy

Finishing what we started.
80 stars 7 forks source link

Jabo_Dsound.dll fails to intialise #112

Closed TheGent closed 6 months ago

TheGent commented 6 months ago

Jabo Audio

Jabo_Dsound.dll fails to intialise using Windows 7 64 Bit

Squall-Leonhart commented 6 months ago

Requires MSVCP71/MSVCR71, this must be app bundled, there is no Redistributable for VS.net runtimes

XP zip package will be affected as well.

TheGent commented 6 months ago

Hmm OK thank you. I will have to check my other machines for this

Squall-Leonhart commented 6 months ago

It is technically installed by the Dot Net 1.1 installer, but 1.0 and 1.1 are install blocked on 7+ unless using a custom MSI

the VCR71 runtime might not be required, the VCP71 will be, these are C and C++ respectively

Fanatic-64 commented 6 months ago

I have a Windows XP VM with .Net 1.1 installed, I can look for the msvcp71.dll file.

TheGent commented 6 months ago

I will also dig out my xp box just incase

TheGent commented 6 months ago

Okay it seems this was the result of my PC dying and it slowly removing everything from the system. I have just tried it on Vista and there is no issue, also on another Windows 7 desktop and there is no issue. I am now installing Windows 10 on the main computer and seeing if that resolves the issue on that as well.

TheGent commented 6 months ago

Hmm, seems to be happening on Windows10 also. Anyone else?

TheGent commented 6 months ago

Ok problem solved: Had to perform a comment out in Plugin.c on

Line 107 //if (AiRomOpen == NULL) { return FALSE; }

TheGent commented 6 months ago

Solved with Plugin.c on Line 107 //if (AiRomOpen == NULL) { return FALSE; }

Squall-Leonhart commented 6 months ago

thats not a fix, all you're doing is masking plugin load failures.

TheGent commented 6 months ago

I never said it was a fix, i said it was solved by. Obviously this needs a permanent solution, but for now so Jabo sound can be used, it bypasses.

Azimer commented 6 months ago

Is this a problem with XP support or gent's failing computer support? I've loaded up PJ64 1.6 many times on fresh XPSP3 builds and never had this problem. I do not guarantee some other software I installed didn't already install the runtime. I agree with squall - Taking out a check to ensure the plugin is in compliance with spec is not the solution if there's an alternate solution such as bundling the redist.

Squall-Leonhart commented 6 months ago

This is interesting, on windows 11 atleast the msvcp_win library is sufficient to enable the plugin to work.