pjamesjoyce / lcopt

Create foreground LCA models via an intuitive user interface and analyse them using Brightway2
BSD 3-Clause "New" or "Revised" License
22 stars 6 forks source link

Try and find a quicker alternative to `recurse_tagged_database` #25

Closed pjamesjoyce closed 6 years ago

pjamesjoyce commented 6 years ago

presamples makes recalculating brightway LCA objects with different methods and parameter sets lightning fast.

The full analysis calculation still drags because of the need to explore the whole graph for each method for each parameter set e.g. from recent project:

Maybe look into exploring the whole foreground graph once then recharacterising the tagged groups per method? (groups don't change between iterations)

pjamesjoyce commented 6 years ago

Benchmark analysis time down to 2 minutes with new analysis setup - it's a start - 25% faster...

pjamesjoyce commented 6 years ago

Slightly new approach to the analysis step

Benchmark analysis is down to 1 min 8 seconds - more than twice as fast as before.

Details in brief

@cmutel: If you think that a version of the tagged analysis that can use multiple methods and has secondary tags would be useful for bw2analyzer proper I'm happy to write them up as a pull request (with the proper tests etc.)

cmutel commented 6 years ago

@pjamesjoyce Yes, please do!