search

pjamesjoyce / lcopt

Create foreground LCA models via an intuitive user interface and analyse them using Brightway2
BSD 3-Clause "New" or "Revised" License
22 stars 6 forks source link

keep autodownloaded files in ecoinvent folder #52

Closed pjamesjoyce closed 6 years ago

pjamesjoyce commented 6 years ago

Waiting for haasad/EcoInventDownLoader#9 before merging

haasad commented 6 years ago

merged!

haasad commented 6 years ago

Hi James, I just released a new version of eidl, which makes this PR mostly obsolete. Downloads are now stored in eidl's own appdirs folder and the download is skipped if it's already present and you provide version and system_model kwargs to get_ecoinvent. Everything should work out of the box.

Sorry on one hand for making you work on these PRs and then rewriting everything myself, but on the other hand thank you for giving me the incentive to look at this again. I feel it's cleaner if you don't have to copy paste large sections of eidl-code that when then both have to maintain, eg: https://github.com/pjamesjoyce/lcopt/blob/a79e9100c618fae9d1da498875d99720b0073655/lcopt/utils.py#L389-L409

I think the only thing that's left in this PR that you probably want to merge are all the create_core_migrations bits: https://github.com/pjamesjoyce/lcopt/blob/a79e9100c618fae9d1da498875d99720b0073655/lcopt/utils.py#L204

pjamesjoyce commented 6 years ago

@haasad - works perfectly - no need for this PR any more. Thanks!