search

pjanuario / pyecoforest

Python library for ecoforest local device.
MIT License
1 stars 2 forks source link

Support for ASHP/GSHP units, such as EcoGeo series #19

Open ostracon opened 10 months ago

ostracon commented 10 months ago

Is your feature request related to a problem? Please describe. I noticed there are some issues on here and the Home Assistant repo (https://github.com/home-assistant/home-assistant.io/issues/30031) related to supporting other EcoForest units. I have an EcoGeo unit, with an Easynet card and would like to at least get measurement information from the unit into HA as well, however I've found some differences in the API with the unit I have that I suspect are shared with other units.

Describe the solution you'd like I used your existing code as a basis for a bare-bones / proof-of-concept API client for the EcoGeo unit I'm running here: https://github.com/ostracon/ecoforest-ecogeo-api/blob/main/ecoforest/api.py

I would ideally like to get this code up to a level where I could open a PR, but as well as improving my own code quality/documentation, I think due to the marked differences in the API, a refactor of pyecoforest might be needed that provided separate classes specific to different units or classes of unit (e.g. GSHP, ASHP, Pellet stove), depending on how Ecoforest have separated things out, as well as the underlying common API. I'm open to ideas and happy to contribute though!

rholighaus commented 6 months ago

I also have two EcoGeo units with Easynet and would prefer a solution that integrates into Home Assistant using the Easynet instead of having to experiment with modbus myself. Happy to be a tester / pilot integrator if wanted. Can provide VPN access for testing if anybody needs to implement.

bytestorm commented 4 months ago

I've spent a few days building a PoC based on HA ecoforest integration to communicate with the EcoGeo heat pump. This heat pump has an entirely different API (which looks more like "modbus HTTP API"). The implementation is quick, dirty and requires way more time to make a proper integration out of it. Here it is: https://github.com/bytestorm/ecoforest_ecogeo

rholighaus commented 4 months ago

I've spent a few days building a PoC based on HA ecoforest integration to communicate with the EcoGeo heat pump. This heat pump has an entirely different API (which looks more like "modbus HTTP API"). The implementation is quick, dirty and requires way more time to make a proper integration out of it. Here it is: https://github.com/bytestorm/ecoforest_ecogeo

Please let me know if you need help in testing.

bytestorm commented 4 months ago

Please let me know if you need help in testing.

@rholighaus

That would be great. It works fine for me so far, but testing is definitely needed in order to improve it (despite the fact that it begs for refactoring). You can install it by adding my repo to HACS as a custom repository to try it out. Feel free to create gh issues in that repo to add/fix/improve existing functionality since I've made just a basic set of stuff I needed.