Open ghost opened 5 years ago
Thanks for the pull request but whole repository-wide search-and-replace of NULL with nullptr is not really the way to go nor do I see any reason to do this.
Most of the affected files would be libraries anyway - mainly Box2D but I also saw SDL headers getting NULL replaced with nullptr which is not good as SDL is pure C lib (even if it's just in the comments).
You're right, I'll rebase. Edit: Should be ok now.
"nor do I see any reason to do this."
Do you mean, you don't see advantage of using nullptr
?
NULL
is just zero, so it's able to implicit cast and call another (overloaded) function.
https://isocpp.github.io/CppCoreGuidelines/CppCoreGuidelines#Res-nullptr
Yes I know the difference between NULL and nullptr ;) Any new code based on C++11/14/17 standard should use nullptr instead of NULL.
Nonetheless, I really do not like the idea of even project-wide search-and-replace which in effect does not solve anything. Even more so when I do not work on this project anymore.
Have to run in android too java runner. I found a game for smartphone too :D
Some zeros have also been replaced.