pjasiun / fuma

Fussball Manager for Slack
MIT License
4 stars 4 forks source link

Disallow optimized teams in randomize match #57

Open jodator opened 6 years ago

jodator commented 6 years ago

As in title.

If match is randomized 🎰 then it should always be different then optimized by rank match.

fredck commented 6 years ago

It should be left in the hands of the destiny! ❤️

pjasiun commented 6 years ago

:-1: Because it's not that simple. Now we have:

1/3 of random matches are fully unbalanced (1&2 vs 3&4), 1/3 of random matches are partially balanced (1&3 vs 2&4), 1/3 of random matches are balanced (1&4 vs 2&3).

If we want to be able to manipulate it for real it should not be just a configuration options: how many matches are balanced and the rest is fully unbalanced or partially balanced. It should be possible to define what percent is fully unbalanced what is partially balanced and what is balanced:

n of matches are fully unbalanced (1&2 vs 3&4), m of matches are partially balanced (1&3 vs 2&4), k of matches are balanced (1&4 vs 2&3).

What you propose is to have:

n 1/2 of matches are fully unbalanced (1&2 vs 3&4), n 1/2 of matches are partially balanced (1&3 vs 2&4), 1-n of matches are balanced (1&4 vs 2&3).

What we have now: option to have random matches, which can be any of these 3 options is fine for me for now.

jodator commented 6 years ago

n 1/2 of matches are fully unbalanced (1&2 vs 3&4), n 1/2 of matches are partially balanced (1&3 vs 2&4),

It's overcomplication for me... It's either "balanced" or not. You cannot simply state that some games are fully or partially unbalanced (you'd need to make deeper analysis of ranks to state which one ti is ;) )

To be clear I'm proposing:

  1. config of how many matches are "randomized" (randomizeFactor)
  2. make randomized games not the same as default.

That way if you set randomizeFactor to 50% you'd get:

Given that with randomizeFactor 20% you'd get 20% chance of being in unbalanced team.

jodator commented 6 years ago

In other words: seeing 🎰 would mean that the game is not balanced (regular one) and IMHO it's the way to go with this setting (making it lower then 1 like 0.5 or less).