search

pjekel / cbtree

The Dijit Tree with Multi State Checkboxes, project code 'cbtree' , is a highly configurable dojo/dijit tree with support for multi-state checkboxes or third party widgets capable of presenting a so-called 'checked' state.
Other
75 stars 34 forks source link

Make model validation code in cbtree/Tree more consistent #9

Closed vvoovv closed 12 years ago

vvoovv commented 12 years ago

Now we have in the cbtree/Tree: this.connect(model, "onStoreComplete", "_onModelValidated"); model._validateData();

I'd suggest: this.connect(model, "onDataValidated", "_onModelValidated"); model.validateData();

So I propose to rename in the cbtree/StoreModel onStoreComplete -> onDataValidated _validateData -> validateData

pjekel commented 12 years ago

Agreed and done.

-----Original Message----- From: Vladimir Elistratov [mailto:reply@reply.github.com] Sent: Monday, April 09, 2012 5:45 AM To: pjekel Subject: [cbtree] Make model validation code in cbtree/Tree more consistent (#9)

Now we have in the cbtree/Tree: this.connect(model, "onStoreComplete", "_onModelValidated"); model._validateData();

I'd suggest: this.connect(model, "onDataValidated", "_onModelValidated"); model.validateData();

So I propose to rename in the cbtree/StoreModel onStoreComplete -> onDataValidated _validateData -> validateData

Reply to this email directly or view it on GitHub: https://github.com/pjekel/cbtree/issues/9