search

pjf / WebService-HabitRPG

Access the HabitRPG API from Perl
8 stars 5 forks source link

Move away from given/when #34

Closed hoelzro closed 10 years ago

hoelzro commented 10 years ago

given and when cause warnings on later perls. I also improved the message printed when the user doesn't have a configuration file.

Thanks for writing this module! I'm hoping it makes my HabitRPG experience that much better. =)

pjf commented 10 years ago

You rock, thank you!

Although it looks like we don't need 6cb7f0f, as AutoPrereqs automatically picks up Moo correctly. It's only the crypto-related modules that it has trouble determining automatically. (Ideally we don't want any explicit depends in dist.ini, because then if we stop depending on Moo for any reason, dzil will do the right thing.)

I'm happy to merge this now and rebasing out the Moo change, although if you want to do that on your branch before I merge that's just as good for me. :D

Thanks again for being TOTALLY AMAZING!

<3 Paul

hoelzro commented 10 years ago

Makes sense to me! I've rebased the Moo change out, so it's ready when you are.

pjf commented 10 years ago

I adore you!

Merging now, testing once I've done coffee with a friend, releasing tonight. :D

pjf commented 10 years ago

Released! Apologies for the week's delay! :)

pjf commented 10 years ago

Er, maybe not... just got a test failure. :)

(Not involving your code, I suspect a bit-rotted test)

pjf commented 10 years ago

Okay, now released for real. Thank you, you rock! :)

hoelzro commented 10 years ago

Thanks!