pjf / ipc-system-simple

Perl module to make running system commands and capturing errors as simple as possible.
http://search.cpan.org/perldoc?IPC::System::Simple
Other
19 stars 20 forks source link

Win32 Fixes #38

Open TBSliver opened 4 years ago

TBSliver commented 4 years ago

this PR fixes various test issues found in #37

The biggest two are: when running a perl under Portable $Config{perlpath} is tainted due to having to compute that path at runtime, meaning the entire t/07_taint.t test explodes. Not sure how to fix otherwise, so if Portable is loaded then Ive set it to skip the entire test - better versions welcome.

The other issue is when the perlpath itself contains a space. To fix this, all usages of $perl_path when used in single argument mode have been quoted.

These tests have been checked working on a perl 5.30.2 running on Windows 10 under psperl and on a perl 5.20.1 on Debian under perlbrew.

Comments and improvements welcome!