pjf / masterwork-dwarf-fortress

Patches and bugfixes applied to Meph's amazing Masterwork Dwarf Fortress
33 stars 22 forks source link

Missing child/baby names. #22

Closed splintermind closed 10 years ago

splintermind commented 10 years ago

TAME_GENIE, PEKYT, PEKYT_GIANT, MOTH_SILK, COCHINEAL, and BANE_SPIDER creatures in creature_pet_masterwork.txt are missing both GENERAL_CHILD_NAME and GENERAL_BABY_NAME tokens.

This is a minor issue which I noticed when debugging therapist, as those creature's offspring show up with no name.

pjf commented 10 years ago

Nice spot! :)

Don't hesitate to beat me to it when it comes to fixing this. ;)

ghost commented 10 years ago

I guess it's too minor to care. I'll get it, but I'm new to git :( sorry if I screw something up

splintermind commented 10 years ago

No, no, we care, we're just very busy (well that and I've been trying to find unique/interesting animal offspring names for these hybrids)! I've had to add extra checks into Dwarf Therapist to deal with these missing names, but I'd prefer to fix things up properly, that's why it's been reported.

splintermind commented 10 years ago

Yes that's correct.http://dwarffortresswiki.org/index.php/DF2012:Creature_token#G

On Tue, Dec 3, 2013 at 5:19 PM, ctrenthem notifications@github.com wrote:

I don't know how to send a message to a user (again, newb), but just a quick verification. Is this the proper format for the tokens?

[GENERAL_BABY_NAME:genie:genies]

— Reply to this email directly or view it on GitHubhttps://github.com/pjf/masterwork-dwarf-fortress/issues/22#issuecomment-29723989 .

-josh

--my divinity is caught between the colors of a butterfly--

pjf commented 10 years ago

Oh, we definitely care! The first step of fixing a bug is knowing that it exists. :)

And patches are definitely welcome! :)

(If you're doing the whole fork and pull thing, then basing your fork off master is usually the best option.)

~ pjf

pjf commented 10 years ago

Fixed with @Undeadlord's excellent work, and merged into gold. :)