Obscure syndrome names.

[splintermind]

Syndromes which share the same names should be re-named with unique descriptions.

For example, interaction_biology.txt has sets of ' Biology Interaction' syndromes, which should be re-named to identify what bonus the syndrome is actually giving (double damage, no stun, etc.)

This is also an issue with the speaker's podium; all speeches simply give "inspired by a speech (permanent)".

These changes are mostly to provide easy identification for the syndromes/reactions when viewing them with things like dfhack and dwarf therapist.

[pjf]

I'm pretty sure the "Even legendary athletes" message is being used as header text. These reactions have no skill associated with them, and no products or reagents, so instead they produce a header when looking at the workshop:

= Workbench =
*Trains Strength,Agility,Toughness,Spatial/Kinetic*
*Even legendary Athletes still gain attribute boni*

How are the biology interactions showing? Do they just display Goblin Biology Interaction? I agree if nothing else that putting a level in there would help (eg: Goblin Biology Lv 1).

[splintermind]

I'm not sure if it can be fixed, but what I meant about the jobs is that the headers are used as the reaction text. For example with the weight bench, in Therapist you'll see: trains Strength,agility,toughness,spatial/kinetic as the current job. It's really a minor detail, I just think it's a bit... messy?

The biology interactions show up as simply 'Goblin Biology Interaction', so it's impossible to tell what they actually do. While putting the level is a step in the right direction, I think having a brief description would be more beneficial to know exactly what the syndrome is doing. Without looking at the raws, there's no indication of what 'level 1' vs 'level 2' is, or what biology workshop reactions are associated to them.

[pjf]

Wha? The weight bench should have a few reactions:

[REACTION:WORK_OUT_TITLE1]
        [NAME:*Trains Strength,Agility,Toughness,Spatial/Kinetic*]
        [BUILDING:TRAINING_DWARF:NONE]

[REACTION:WORK_OUT_TITLE2]
        [NAME:*Even legendary Athletes still gain attribute boni*]
        [BUILDING:TRAINING_DWARF:NONE]

[REACTION:WORK_OUT1]
        [NAME:Work out]
        [BUILDING:TRAINING_DWARF:CUSTOM_A]
        [PRODUCT:100:10:BOULDER:NONE:INORGANIC:SWEAT]
        [SKILL:MISC_WEAPON] 

[REACTION:WORK_OUT2]
        [NAME:Work out - Medium (Any Metal Bar)]
        [BUILDING:TRAINING_DWARF:CUSTOM_B]
        [REAGENT:A:150:BAR:NONE:INORGANIC:NONE][REACTION_CLASS:IS_METAL]
        [PRODUCT:100:1:BAR:NONE:GET_MATERIAL_FROM_REAGENT:A:NONE][PRODUCT_DIMENSION:150]
        [PRODUCT:100:20:BOULDER:NONE:INORGANIC:SWEAT]
        [SKILL:MISC_WEAPON] 

Unless one is trying to use the dummy "Trains Strength,Agility,Toughness..." reaction, I'd expect therapist to show Work out or Work out - Medium (Any Metal Bar). Am I confused?

And yes, I agree that full descriptions for the biology interactions are the right way to go. I'm looking at the raws and still not sure what each level does.

[splintermind]

Yes, you're correct, it seems I accidentally had one of the weight benches using the title reaction.

[pjf]

Excellent! Updating the head note on this issue. :)

[pjf]

@splintermind has done some great work at e7f7c310770815540feacf939dad92a141029041 . Shall be integrating later today. :)