search

pjf / masterwork-dwarf-fortress

Patches and bugfixes applied to Meph's amazing Masterwork Dwarf Fortress
33 stars 22 forks source link

Update living rock reactions #34

Closed pjf closed 10 years ago

pjf commented 10 years ago

According to http://www.bay12forums.com/smf/index.php?topic=125630.msg4807494#msg4807494 living rock no longer drops boulders.

We should either update the manual and RAWs so living rock reactions (eg: butchering for meat) are no longer mentioned, or update the living rock raws so that they actually drop boulders.

Resolution: Not a bug, only sub-clusters drop boulders. See discussion below.

Meph248 commented 10 years ago

Wrong. You didnt check the raws, before submitting this. There are two entries of living rock. Large clusters that produce blood puddles, and small clusters that drop solid boulders. The small clusters can only be found in the large clusters.

[INORGANIC:BAUXITE] [USE_MATERIAL_TEMPLATE:STONE_VAPOR_TEMPLATE] [STATE_NAME_ADJ:ALL_SOLID:living stone][DISPLAY_COLOR:4:0:1][TILE:176] was 133 -ENVIRONMENT:SEDIMENTARY:CLUSTER:100- [ENVIRONMENT:METAMORPHIC:CLUSTER:40] [STATE_NAME:ALL_SOLID:living stone] [STATE_ADJ:ALL_SOLID:living stone] [STATE_NAME:LIQUID:blood] [STATE_ADJ:LIQUID:blood] [STATE_NAME:GAS:blood gas] [STATE_ADJ:GAS:blood gas] [MAT_FIXED_TEMP:10000] [MELTING_POINT:9000] [BOILING_POINT:15000] [MATERIAL_VALUE:0]

[INORGANIC:BAUXITE2] [USE_MATERIAL_TEMPLATE:STONE_TEMPLATE] [STATE_NAME_ADJ:ALL_SOLID:living stone][DISPLAY_COLOR:4:0:1][TILE:176] was 133 [ENVIRONMENT_SPEC:BAUXITE:CLUSTER_SMALL:150] [MATERIAL_VALUE:7] [STATE_NAME:ALL_SOLID:living stone] [STATE_ADJ:ALL_SOLID:living stone] [STATE_NAME:LIQUID:blood] [STATE_ADJ:LIQUID:blood] [STATE_NAME:GAS:blood gas] [STATE_ADJ:GAS:blood gas] [IS_STONE]

I took the original bauxite and replaced it with the living stone, because it uses the same color, in case you want to ask about the IDs. ;)

splintermind commented 10 years ago

On a related note, I propose 'as-accurate-as-possible' naming of 'all-the-things' whenever possible. The raws are in pretty rough shape due to all the copy pasting that's happened during development. It just makes hunting down raw entries that much more difficult due to vague or simply bad naming.

pjf commented 10 years ago

You'll find that for most of the bugs I haven't checked the raws. My actual knowledge of DF modding is really quite limited. To be honest I wouldn't have been able to tell from the raws above that there were clusters that drop boulders. In fact, I still can't tell; is it the [IS_STONE] that causes the boulders to drop, or some other tag?

Consequently, when someone reports a bug, I record it here. If it's not actually a bug, then I get to close it (and I have a record later if someone has the same report). If it is a bug, then we celebrate, because knowing about bugs is much better than not knowing about them.

So expect to find a lot of entries which aren't actually bugs. I'll be delighted to close them. :)

~ pjf

Meph248 commented 10 years ago

Its not IS_STONE, thats only for the stockpiles. The difference is [MAT_FIXED_TEMP:10000] on the other, which causes it to form a puddle of liquid.