search

pjf / masterwork-dwarf-fortress

Patches and bugfixes applied to Meph's amazing Masterwork Dwarf Fortress
33 stars 22 forks source link

Make a fork for the DFHack r4 update #4

Closed Putnam3145 closed 10 years ago

Putnam3145 commented 10 years ago

It could get messy, so it'd be good to make a fork.

pjf commented 10 years ago

Oh hey! I was in the process of investigating this last night. I know that MWDF 4c uses r3, and there's almost certainly been some updates and tweaks to that, but I'm not sure what they are.

It might make sense to prepare diffs between vanilla r3 and Masterwork r3, so we can figure out what (if anything) should be reapplied to r4.

I definitely agree that a branch is in order here, there's no way I'm going to be applying r4 directly onto the master branch. :)

Guidance and direction are definitely appreciated here. I know that you know your way around DFHack, whereas I'm still poking around figuring out how everything fits together. :)

pjf commented 10 years ago

Oh hey, https://github.com/Putnam3145/masterwork-dwarf-fortress/ looks awesome. :D

Putnam3145 commented 10 years ago

I've already gotten a bunch of changes written up, I'm just waiting to make a pull request.

pjf commented 10 years ago

Excellent!

In my head I seemed to think that github lets me throw pull requests on to arbitrary (and potentially not-yet existing) branches. However I'm not sure if that's actually the case, so there's a dfhack_r4 branch waiting for you. :)

pjf commented 10 years ago

Closing this because we have a branch. :)