search

pjf / masterwork-dwarf-fortress

Patches and bugfixes applied to Meph's amazing Masterwork Dwarf Fortress
33 stars 22 forks source link

Updating Saved Games #85

Closed splintermind closed 10 years ago

splintermind commented 10 years ago

Updating the graphics on saved games (via the GUI) is pretty sketchy. I've tried it with a few tilesets, and things seem to be very broken.

The raws in the graphics packs need to be looked at, specifically the plants/grasses and the inorganics/warpstone files (those were the ones causing the issues changing from masterwork-phoebus-walls to phoebus)

Maybe updating save raws should be disabled for now...

pjf commented 10 years ago

Wait, you can change the graphics in your saves? That's almost guaranteed to cause pain!

Some of the graphics define more grasses than others. I tried to harmonise them so they all had the same number of grasses (while keeping the graphics-specific colours and tiles), but apparently Meph was unhappy with the results.

The warpstones files have always been out-of-sync between tilesets. I've not tried to correct them, because syndromes are hard.

The show-tilesets-diffs.pl program emits changes it thinks it can correct automatically (on stdout) and ones which need manual attention (on stderr). It's a huge hack, but it's good for spotting bugs which have been introduced.

I can see that the ASCII and Ironhand tilesets are missing some creature classes, vermin in CLA seem to be missing souls (or have souls in different spots), and almost everything seems to have broken YESSECRET tags for spying out production facilities.

Oh, and kobold bulbs only exist in are gone in everything but Ironhand, Masterwork, Obsidian and Phoebus, although I'm sure we fixed that somewhere... (Although maybe I'm mis-remembering...)

With the raws as they are, I'd never allow tileset changing. :/

splintermind commented 10 years ago

Yeah previously there was an oversight in the GUI that never made the button visible. It comes with a big warning, but states that if you haven't changed any options, you can change the tilesets. Seems like bullshit to me after trying it out.

pjf commented 10 years ago

There was an oversight in the GUI that never made the button visible

Let's call that an accidental feature. :)

splintermind commented 10 years ago

I specialize in those..

pjf commented 10 years ago

Cherry-picked 087fa119564e72ad5f539655c229bb9054aa87cc into master, and closing.

(Feel free to re-open if you think this ticket should be...)