search

pjg711 / oauth-php

Automatically exported from code.google.com/p/oauth-php
MIT License
0 stars 0 forks source link

Do not add a oauth_token on requesting requesttoken #83

Closed GoogleCodeExporter closed 8 years ago

GoogleCodeExporter commented 8 years ago 
What steps will reproduce the problem?
1. Request a request token to the Opera oauth system 
(http://www.opera.com/docs/apis/linkrest/oauthexamples/)

What is the expected output? What do you see instead?
Expected: a valid requesttoken
What the real result is: wrong signature.

What version of the product are you using? On what operating system?
php 5.3.2 / linux

Please provide any additional information below.
Do not add oauth_token (also not a empty one) on a request for requesttoken:  
(its not required on this request)
http://code.google.com/p/oauth-php/source/browse/trunk/library/OAuthRequestSigne
r.php?r=167#131

Do not make it required on a request for request token
http://code.google.com/p/oauth-php/source/browse/trunk/library/OAuthRequest.php?
r=167#189

Original issue reported on code.google.com by ourtechnology@gmail.com on 22 Nov 2010 at 3:00

GoogleCodeExporter commented 8 years ago 
Fixed on r168, thanks. Could you test it please and confirm it's working as 
expected?

Original comment by brunobg%...@gtempaccount.com on 23 Nov 2010 at 5:31

GoogleCodeExporter commented 8 years ago 
The requesting a requestToken works. But when requesting a accessToken the 
oauth_token should be added. How about adding a parameter to the sign method 
with the type (adding token ore not) or moving the setParam('oauth_token' to 
the doRequest and requestAccessToken? (not tested)

Check http://dev.twitter.com/pages/auth#intro for the required parameters

Original comment by ourtechnology@gmail.com on 23 Nov 2010 at 9:29

GoogleCodeExporter commented 8 years ago 
I did that. requestToken requests do not have oauth_token anymore, while all 
the other requests do have it. I hope this patch fixes the problem, please let 
me know.

Original comment by brunobg%...@gtempaccount.com on 24 Nov 2010 at 1:36

GoogleCodeExporter commented 8 years ago 
BTW, the twitter test in client/ is working.

Original comment by brunobg%...@gtempaccount.com on 24 Nov 2010 at 3:14

GoogleCodeExporter commented 8 years ago 
[deleted comment]
GoogleCodeExporter commented 8 years ago 
Its also working with opera.

Original comment by ourtechnology@gmail.com on 24 Nov 2010 at 7:41

GoogleCodeExporter commented 8 years ago 
Cool. Closing this, thanks :)

Original comment by brunobg%...@gtempaccount.com on 24 Nov 2010 at 7:47