search

pjheslin / diogenes

Diogenes: an environment for reading Latin and Greek
https://d.iogen.es/d
Other
56 stars 10 forks source link

Tullius pro Tullio #72

Closed helmadik closed 3 years ago

helmadik commented 3 years ago

Somehow when I enter a section of the Pro Tullio, I am dumped at the end of the text. Entering 16 manually, in 'Read a Text' > Cicero > Pro Tullio. Working with version 4.5a.

MillerKrause commented 3 years ago

This also happens on Diogenes 3.1.6. In both 3.1.6 and 4.5, entering section 1 takes the user to the beginning, but 2 or higher takes the user to the end of the text. Pro Tullio is 0474: 006. Likewise in PHI>Quintilian (1002)>Declamationes Minores (1002: 002), no non-zero value for "Oration" seems to work right. Likewise in TLG>Aesopus (0096)>Fabulae (0096: 002), values for "Fable" up to 60 work fine, but 61 takes you to fable 292.

pjheslin commented 3 years ago

Thanks to you both for these super-helpful bug reports. Fortunately, these are easy to fix. The databases include a kind of table of contents for all works, which indicate the last text citation in each 8K block. This goes back to the days when computers were too slow to plough through a whole text from the start to find a passage. The ToC works fine when the citations are straightforwardly consecutive, but there can be problems when they are not. And there are quite a few bugs in the ToC contents, because I don't think this feature was tested much.

Diogenes tries to use the ToC, but there is a blacklist of authors for which it is unreliable, and for these we just search from the start of the text. I have added Cicero, Quintilian and Aesop to that list, and that fixes these bugs (commit 5e6adf206647346bba6ffe7914f621bcdc03e987).

I am tempted to disable the ToC for all authors, since computers are so much faster now, but there may be people out there with very old hardware for whom this would cause a noticeable slowdown. So for the time being, please report any more of these issues you find, and I'll keep adding authors to the blacklist.

helmadik commented 3 years ago

Since the last release we have also done more work on the citations (Terence, Cicero, some Apuleius on the way), but yes, the Declamations seemed to be especially tricky to get to work..

Helma Dik Department of Classics University of Chicago

On Thu, Jul 8, 2021 at 4:49 AM pjheslin @.***> wrote:

Closed #72 https://github.com/pjheslin/diogenes/issues/72.

— You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub https://github.com/pjheslin/diogenes/issues/72#event-4993888114, or unsubscribe https://github.com/notifications/unsubscribe-auth/ABZLI4IVFWJ7H42UKGFEKALTWVYB3ANCNFSM4X7JS4EA .

pjheslin commented 3 years ago

Fantastic! I assume you mean more work in fixing the citations in Lewis and Short.

helmadik commented 3 years ago

Yes:-)

On Thu, Jul 8, 2021 at 08:53 pjheslin @.***> wrote:

Fantastic! I assume you mean more work in fixing the citations in Lewis and Short.

— You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub https://github.com/pjheslin/diogenes/issues/72#issuecomment-876458467, or unsubscribe https://github.com/notifications/unsubscribe-auth/ABZLI4OPQ47R2WB4XVWNSLDTWWUU3ANCNFSM4X7JS4EA .

-- Helma Dik Department of Classics University of Chicago

MillerKrause commented 3 years ago

In case someone's looking to patch diogenes 3 or 4, the blacklist mentioned above is in server/Diogenes/Browser.pm around line 155; search for "Skipping ToC" and add tlg/phi numbers to the if statement surrounding it.

pjheslin commented 3 years ago

I'm hoping to release a new version by the end of September. And I hope no one is still using version 3!