search

pjkersten / PlantUML

PlantUML plugin for MediaWiki
34 stars 17 forks source link

dependencies not documented #18

Open RockScience opened 8 years ago

RockScience commented 8 years ago

Does this depend on the Graphviz extension? It is not clear...

cotto commented 7 years ago

I updated https://www.mediawiki.org/wiki/Extension:PlantUML to reflect the fact that Extension:GraphViz isn't actually necessary. Hopefully the edit sticks because I'm a little miffed at wasting two days getting ImageMap and GraphViz working on Windows.

cotto commented 7 years ago

For the sake of documentation, I think this extension does sneakily depend on ImageMap. It integrates in the jankiest way possible (implicitly assuming that it exists). Overall this extension is very low-quality code and would greatly benefit from a maintainer. I wouldn't recommend depending on it unless you have the time to clean it up too. Unfortunately I don't have that time.

edit: I also reverted my edit to the extension page.

WolfgangFahl commented 7 years ago

Thanks for your comments. As a maintainer I appreciate your comment about the great benefit I am to this package. See: https://www.mediawiki.org/wiki/User_talk:Legoktm#Adding_Extension_PlantUML_to_packagist

for how the dependency issue may be solved in the future. Composer.json has been prepared quite a while for this extension. Personally I think the graphviz dependency is fully ok. It makes a lot of sense to have graphviz alongside PlantUML and in the future there may even be some use of this dependency.

cotto commented 7 years ago

Hi @WolfgangFahl. If you're open to suggestions, I'm happy to create tickets for specific issues that I've run into. The code is bad but totally fixable and I'd love to be able to deploy it in my environment. I looked at the commit history and assumed that it wasn't maintained; I'm happy to see that you're still active.

WolfgangFahl commented 7 years ago

@cotto Thanks for volunteering. You are most welcome to participate. This is what opensource is about.

cotto commented 7 years ago

I finally had a minute to file some issues. I don't know if I'll have time to submit fixes (I'll try but work is quite busy) but I will at least test and review changes.