pjkundert
commented
8 years ago Richard;
Thanks for the report. Yes, the Tag parsing code in Cpppo is presently pretty simplistic. Asking for elements of arrays of structs is pretty sketchy, at this point. In the first example, you are successfully asking for the data, but the response parser probably isn't capable of parsing the data response. In the second example, the simplistic Tag parser is erroneously handling the two indices.
I would recommend trying the first approach, and increasing the verbosity (add -vvv to the CLI command-line). Then, send me the logging output. I should be able to diagnose why the response is not being parsed.
I'll work on the Tag parsing code, to properly parse multi-level tags with multiple indices. In the mean time, you can hand-assemble arbitrarily complex EPATHs (instead of using the Tag parser):
python -m cpppo.server.enip.client --print -vvv '@{"symbolic":"JugARecipeName"}/{"element":0}/{"symbolic":"DATA"}'Unfortunately, the element count supplied to the Read Tag [Fragmented] request in these cases is always == 1, so our options are limited to asking for a single element of whatever EPATH you provide...
The EPATH segments that you can ask for (each in a separate JSON dict) are:
symbolic
element
class
instance
connection
attribute
port, link
karmicthreat
datasim
So I am trying to read a string that is part of an array of strings out of a AB CompactLogix L18ER. With the structure JugARecipeName STRING[32] and the DATA tag inside is SINT[82] so 32 strings with a length of 82. I get a ValueError: too many values to unpack (expected 2) if I try to read one element. But I can't seem to read JugARepcipeName[1] or JugARecipeName[1].DATA as I just get 'cpppo.automata.NonTerminal: ( data.( select.((noop)) ) ) sub-machine terminated in a non-terminal state' am I doing something wrong to read this?
Examples below:
python3 -m cpppo.server.enip.client -a 192.168.2.210 -l cpppo.txt --print 'JugARecipeName[1].DATA' Traceback (most recent call last): File "/usr/local/Cellar/python3/3.5.1/Frameworks/Python.framework/Versions/3.5/lib/python3.5/runpy.py", line 170, in _run_module_as_main "main", mod_spec) File "/usr/local/Cellar/python3/3.5.1/Frameworks/Python.framework/Versions/3.5/lib/python3.5/runpy.py", line 85, in _run_code exec(code, run_globals) File "/usr/local/lib/python3.5/site-packages/cpppo/server/enip/client.py", line 1609, in
sys.exit( main() )
File "/usr/local/lib/python3.5/site-packages/cpppo/server/enip/client.py", line 1590, in main
fragment=fragment, printing=printing, timeout=timeout )
File "/usr/local/lib/python3.5/site-packages/cpppo/server/enip/client.py", line 1366, in process
transactions = list( self.results( operations=operations, _kwds ))
File "/usr/local/lib/python3.5/site-packages/cpppo/server/enip/client.py", line 1358, in results
for idx,dsc,req,rpy,sts,val in self.operate( operations, _kwds ):
File "/usr/local/lib/python3.5/site-packages/cpppo/server/enip/client.py", line 1353, in operate
for idx,dsc,req,rpy,sts,val in harvested:
File "/usr/local/lib/python3.5/site-packages/cpppo/server/enip/client.py", line 1243, in validate
for index,descr,request,reply,status,val in harvested:
File "/usr/local/lib/python3.5/site-packages/cpppo/server/enip/client.py", line 1218, in pipeline
col = next( harvester )
File "/usr/local/lib/python3.5/site-packages/cpppo/server/enip/client.py", line 1150, in harvest
issued, self.collect( timeout=timeout )): # must be "lazy" zip!
File "/usr/local/lib/python3.5/site-packages/cpppo/server/enip/client.py", line 1075, in collect
response,elapsed = await( self, timeout=timeout )
File "/usr/local/lib/python3.5/site-packages/cpppo/server/enip/client.py", line 832, in await
for response in cli: # if StopIteration raised immediately, defaults to {} signalling completion
File "/usr/local/lib/python3.5/site-packages/cpppo/server/enip/client.py", line 509, in next
for mch,sta in engine:
File "/usr/local/lib/python3.5/site-packages/cpppo/automata.py", line 645, in run
source=source, machine=machine, path=path, data=data, ending=ending ):
File "/usr/local/lib/python3.5/site-packages/cpppo/automata.py", line 1226, in delegate
for which,target in submach: # 75% of runtime is spent inside 'run'
File "/usr/local/lib/python3.5/site-packages/cpppo/automata.py", line 645, in run
source=source, machine=machine, path=path, data=data, ending=ending ):
File "/usr/local/lib/python3.5/site-packages/cpppo/automata.py", line 1226, in delegate
for which,target in submach: # 75% of runtime is spent inside 'run'
File "/usr/local/lib/python3.5/site-packages/cpppo/automata.py", line 645, in run
source=source, machine=machine, path=path, data=data, ending=ending ):
File "/usr/local/lib/python3.5/site-packages/cpppo/automata.py", line 1291, in delegate
raise NonTerminal( "%s sub-machine terminated in a non-terminal state" % ( self ))
cpppo.automata.NonTerminal: ( data.( select.((noop)) ) ) sub-machine terminated in a non-terminal state
python3 -m cpppo.server.enip.client -a 192.168.2.210 -l cpppo.txt --print 'JugARecipeName[1].DATA[0]'
Traceback (most recent call last): File "/usr/local/Cellar/python3/3.5.1/Frameworks/Python.framework/Versions/3.5/lib/python3.5/runpy.py", line 170, in _run_module_as_main "main", mod_spec) File "/usr/local/Cellar/python3/3.5.1/Frameworks/Python.framework/Versions/3.5/lib/python3.5/runpy.py", line 85, in _run_code exec(code, run_globals) File "/usr/local/lib/python3.5/site-packages/cpppo/server/enip/client.py", line 1609, in
sys.exit( main() )
File "/usr/local/lib/python3.5/site-packages/cpppo/server/enip/client.py", line 1590, in main
fragment=fragment, printing=printing, timeout=timeout )
File "/usr/local/lib/python3.5/site-packages/cpppo/server/enip/client.py", line 1366, in process
transactions = list( self.results( operations=operations, _kwds ))
File "/usr/local/lib/python3.5/site-packages/cpppo/server/enip/client.py", line 1358, in results
for idx,dsc,req,rpy,sts,val in self.operate( operations, _kwds ):
File "/usr/local/lib/python3.5/site-packages/cpppo/server/enip/client.py", line 1353, in operate
for idx,dsc,req,rpy,sts,val in harvested:
File "/usr/local/lib/python3.5/site-packages/cpppo/server/enip/client.py", line 1243, in validate
for index,descr,request,reply,status,val in harvested:
File "/usr/local/lib/python3.5/site-packages/cpppo/server/enip/client.py", line 1208, in pipeline
iss = next( issuer )
File "/usr/local/lib/python3.5/site-packages/cpppo/server/enip/client.py", line 932, in issue
for op in operations:
File "/usr/local/lib/python3.5/site-packages/cpppo/server/enip/client.py", line 205, in parse_operations
seg,elm,cnt = parse_path_elements( tag )
File "/usr/local/lib/python3.5/site-packages/cpppo/server/enip/device.py", line 314, in parse_pathelements
elm, = elm.split( ']' )
ValueError: too many values to unpack (expected 2)