search

pjkundert / cpppo

Communications Protocol Python Parser and Originator -- EtherNet/IP CIP
https://hardconsulting.com/products/6-cpppo-enip-api
Other
332 stars 109 forks source link

Incompatibility with Python 3.7 #55

Closed scontini76 closed 5 years ago

scontini76 commented 6 years ago

citing https://docs.python.org/3/whatsnew/3.7.html

async and await are now reserved keywords.

that brings many issues, for example:

>>> import cpppo.server.enip.get_attribute
Traceback (most recent call last):
  File "<stdin>", line 1, in <module>
  File "/usr/local/lib/python3.7/site-packages/cpppo/server/enip/get_attribute.py", line 376
    rsp,ela     = client.await( connection, timeout=self.timeout )
                          ^
SyntaxError: invalid syntax

NOTE: if you have suggestion on how change that function name and you are agree to introduce an API change to accomodate Python 3.7 I can take care of that change.

MPW-waters commented 5 years ago

Is this fix (#57) planned to be incorporated in order to support 3.7?

mjbrisebois commented 5 years ago

This is now fixed in version 4.0.4