search

pjlegato / ring.middleware.logger

Ring middleware to log each request
58 stars 24 forks source link

Enabling support for pre Clojure-1.3 #2

Closed dcj closed 12 years ago

dcj commented 12 years ago

AFAICT, the use of docstrings in 3? def statement is the only thing preventing earlier Clojure versions from using this code. So, here is a version that moves the docstring out, so I can use this. Also, I had to specify my forked version of your clansi, which contains exactly the same modification.....

dcj commented 12 years ago

Two things: 1) Sorry I didn't read more about def and create a pull request that would have been both pre 1.3 compatible, AND retained your doctoring.... 2) I have been totally annoyed with myself and team for still being stuck on Clojure 1.2.1, and this was the straw that broke the camel's back, after pull requested, I went back and led the charge to migrate our codebase to 1.3. Got to 1.3, and then 10 minutes later, we made it to 1.4. So, actually, I guess I no longer care about pre 1.3 support anyway! Sorry for the noise.