search

pjnorton / lochness

0 stars 0 forks source link

Polish coordinator/provider/acomm #48

Open pjnorton opened 8 years ago

pjnorton commented 8 years ago

Issue by TauZero Fri Mar 11 15:56:42 2016 Originally opened as https://github.com/mistifyio/mistify/issues/48

Review function signatures and flows after a real provider (e.g. #40 ) has used them. Find anything that doesn't work well or feels clunky and address before making more providers.

pjnorton commented 8 years ago

Comment by mmlb Fri Mar 11 20:53:39 2016

adding "" for arg in NewRequest is particularly wrong looking. Maybe NewRequest should just take in the args it needs for validation and returns a default+validated-args Request instead of filling it all in.