pjorg / pjorg-puppet-sumo

Install and manage the Sumo Logic collector and its log sources with Puppet.
MIT License
1 stars 12 forks source link

Forge Update #12

Closed gusnuf closed 5 years ago

gusnuf commented 7 years ago

The forge is currently 1.1.0, as is master, but there are tags as high as 1.2.1. Could you please publish the latest to the forge? Thanks.

pjorg commented 7 years ago

Hi @gusnuf; I may eventually do this when I have time, but in the meantime you can use a Puppetfile to have r10k or Code Manager include the version of the module you want.

lreed commented 5 years ago

Hello, I am making some minor additions to this module to make it more flexible for configs etc. However I am building of the latest version here. I need it to be available on Puppet Forge however. If you don't think you are planning to update the version on the Forge, do you mind if I fork, and make my changes , and publish latest to the forge?

Thanks!

pjorg commented 5 years ago

@lreed is there an outstanding pull request with your proposed changes?

lreed commented 5 years ago

I just submitted. Thanks for looking!! And I see the Travis CI stuff, awesone!

pjorg commented 5 years ago

Well, don't get too excited because I don't think the Travis stuff is working...

pjorg commented 5 years ago

Having some cred problems here in .travis.yml. Maybe a bad encrypt operation the first time around?

pjorg commented 5 years ago

Anybody know of a way to test the password in .travis.yml without another release?

ghoneycutt commented 5 years ago

You could try deleting the tag then re-adding it

pjorg commented 5 years ago

Alright. Well. It worked...sort of. The Travis CI build failed, but only because apparently both build jobs tried to upload the Forge update, and after the first one succeeded, the second one choked because the version already exists.

Not sure what to do about that. Need a Travis CI adult. @ghoneycutt, you there?

ghoneycutt commented 5 years ago

Created PR #19 based on another module we have working - https://github.com/sgnl05/sgnl05-sssd

pjorg commented 5 years ago

Awesome work, thanks @ghoneycutt. Version 1.3.3 passed in Travis and uploaded to Forge without issues.

pjorg commented 5 years ago

Well, if anyone wondered if I know what I am doing on GitHub, now they know for sure that I do not.

Forge release is now aligned to most recent GitHub release. Closing this.