search

pjorg / pjorg-puppet-sumo

Install and manage the Sumo Logic collector and its log sources with Puppet.
MIT License
1 stars 12 forks source link

Added support for single source json file #14

Closed ramamaddodi closed 6 years ago

ramamaddodi commented 7 years ago

Update readme file for single file source json

ghoneycutt commented 7 years ago

I'm addressing the TravisCI issues with PR #13

ghoneycutt commented 7 years ago

@ramamaddodi PR #13 was merged. After you address the issues/questions above, please rebase against master and it will pick up the changes needed to allow Travis to pass.

pjorg commented 7 years ago

I don't know, is it really necessary to allow sources to be defined in a single JSON? The whole point of this module is to abstract the source definitions into the Puppet manifest. If you just want to write the JSON yourself you could just hard code the JSON path into your sumo.conf file.

I'm inclined not to include this unless a case can be made.

ramamaddodi commented 7 years ago

Hi @pjorg : Whole point of doing this is to give users option to choose if they want to have a single json file defining all source or individual json file for each source. Also having option of single json file eliminates defining local file resource in puppet class file for each source. This is a good option for users who have sumo collectors with more than 20-25 source type defined per environment, which can be exported as single json file from Sumo UI and imported as template, which is still manage via puppet. Let me know if you need more info from my end.

ghoneycutt commented 7 years ago

@ramamaddodi if you rebase this against master it should pass tests.

ramamaddodi commented 6 years ago

Thank You @ghoneycutt