Open krishanifs opened 2 weeks ago
Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you all sign our Contributor License Agreement before we can accept your contribution.
1 out of 2 committers have signed the CLA.
:white_check_mark: krishanifs
:x: Krishan Nilanga
Impressive changes!
Does this work with pjsip-apps/src/3rdparty_media_sample
?
Formatting seems to be broken in some cases.
Phew, this is pretty comprehensive. Would it not be better to break this up?
This looks like several PRs to me, roughly:
Impressive changes!
Does this work with
pjsip-apps/src/3rdparty_media_sample
?Formatting seems to be broken in some cases.
Regarding this, can you please provide more details I have built 'pjsip-apps/src/3rdparty_media_sample' with proper 'config_site.h' and configure commands. It does not gave me any errors.
Phew, this is pretty comprehensive. Would it not be better to break this up? This looks like several PRs to me, roughly:
- Bugfixes
- Recording
- Confbridge changes
- PJSUA Call changes
I will create separate PRs
change log
• Added new Call recording and play capability through media ports. [pjsip/include/pjsua-lib/pjsua.h] • Added "Get queued DTMF Digits" functionality. [pjsip/include/pjsua-lib/pjsua.h] • A Conference slot and a null port is added to the call and provide the capability of maintaining connectivity while transition between ports. This allows calls to change ports before call setup. [pjmedia/include/pjmedia/conference.h] • New pjsua_call_make_call2 function with source uri and contact uri as input arguments. [pjsip/include/pjsua-lib/pjsua.h] • New pjsua_create2 with pjsua_logging_config as input argument. [pjsip/include/pjsua-lib/pjsua.h] • pj_assert put logs in non-debug modes. • Extend logs in the library. • Add warning to pj_mutex_lock failure.
• Bug fixes in o pjlib/src/pj/os_core_win32.c:pj_thread_local_get o pjmedia/Circbuf:pjmedia_circ_buf_create o pjmedia/src/pjmedia/null_port.c: null_get_frame o pjsip/src/pjsip/sip_transaction.c o pjsip/src/pjsua-lib/pjsua_acc.c o pjsip/src/pjsua-lib/pjsua_media.c: pjsua_media_subsys_init