pjstevns / dbmail

Fast and scalable email services
http://www.dbmail.org
Other
80 stars 33 forks source link

fix detection of systemd libs on systemd >= 230 #45

Open cjmayo opened 7 years ago

cjmayo commented 7 years ago

There was a mistake in https://github.com/pjstevns/dbmail/commit/c6773f6b5ff6d87513c3759565df1700128c7e42 that I missed.

I have tested this change with systemd-226 and systemd-231

cjmayo commented 6 years ago

Updated to quote $SYSTEMD_LIBS to ensure test works.

langemeijer commented 6 years ago

On my stretch build system (systemd-232) I can do aclocal; autoconf; automake; ./configure --with-systemd; make and it will build fine, without your change.

Although configure shows this curious output:

checking for SYSTEMD... no
checking for SYSTEMD... yes
cjmayo commented 6 years ago

Is pkg-config installed?

With this patch configure output should be similar to:

checking for x86_64-pc-linux-gnu-pkg-config... /usr/bin/x86_64-pc-linux-gnu-pkg-config
checking pkg-config is at least version 0.9.0... yes
checking for libsystemd-daemon... no
checking for libsystemd >= 230... yes

And if it has worked near the end:

SYSTEMD:                   -L/lib64 -lsystemd
langemeijer commented 6 years ago

Right! I thought it would work without patch, but indeed your patch is required.

SYSTEMD:                   -lsystemd