pjvds / ncqrs

Ncqrs Framework - The CQRS Framework for .NET
Other
539 stars 164 forks source link

Refactoring DependencyInjection #109

Open sbiaudet opened 7 years ago

sbiaudet commented 7 years ago

In ncqrs, NcqrsEnvironment class act as a ServiceLocator. Few implementation are made in extensions with some IOC frameworks like Autofac, Windsor, ..... This pattern is good and used in lot of projects.

I propose a refactoring to be more compatible with dotnet core. asp.net core and ef core. Using a abstract library called Microsoft.Extensions.DependencyInjection. This library have extensions to used others containers like Autofac, StructureMap. Using this library avoid the need to maintain our own IOC library. So we can shutdown some ncqrs extensions.

What's your feeling ?