search

pjvds / ncqrs

Ncqrs Framework - The CQRS Framework for .NET
Other
539 stars 164 forks source link

Development #58

Closed aweiker closed 13 years ago

aweiker commented 13 years ago

I did some work on documenting and cleaning up MsSqlServerEventStore. I didn't change any functionality but just added completed XML Comments and put members in a structured order.

jasondentler commented 13 years ago

The build was broken before your pull request was applied. It's not your fault. Here's the build log.

After applying your pull request, the build is still broken. Here's the build log.

This is an automated message from GitHub Builder.

aweiker commented 13 years ago

Did you try with changeset 488fd98? I just pulled that in earlier today and fixed the build errors that I had.

jasondentler commented 13 years ago

Here's the base source for this pull request: https://github.com/ncqrs/ncqrs/zipball/67366fc486536859881a123ed1f1e6fdb7138476

Here's the diff it applied: https://github.com/ncqrs/ncqrs/pull/58.diff

The build fails because the Azure dlls are missing.When you install the Azure SDK, does it put them in the gac or some other easy-to-find place?

Thanks for fixing the Windsor dll path issue.

jasondentler commented 13 years ago

Scratch that... it's not applying the patch correctly.

aweiker commented 13 years ago

Azure SDK get's pulled from wherever they are referenced. By default it will do it from the GAC but I always copy them to a 3rd party folder inside my solution to reference them directly.

pjvds commented 13 years ago

Awesome! Documentation, now that puts a smile on my face! Thx