search

pk-fr / yakpro-po

YAK Pro - Php Obfuscator
http://www.php-obfuscator.com
Other
1.29k stars 363 forks source link

Add PHP Parser as git submodule #16

Closed cabloo closed 7 years ago

cabloo commented 7 years ago

Takes a step out of the install process.

pk-fr commented 7 years ago

I Zane,

Thanks for your interest for yakpro-po ... if you like it, please star it...

I do not have any experience with git submodules, but it seems that the submodules are to be updated manually by the user, and will only reflect the last version that has been pulled by the main module.... the user cannot update the submodule directly to the last version...

another reason is that myself, I clone only 1 copy of PHP Parser, and I put symlinks on all my projects using it... so when needed, I update only once for all of them....

I checked "clone --recursive " from your forked version... and it fails! url = git@github.com:nikic/PHP-Parser.git reports "permission denied" git does not seem to be a no-password user of github... perhaps a wrong url?

I do not see at the moment any reason that makes me prefer submodules to the current state... If you are able to convince me by giving me compelling arguments, why not...

Cheers, Pascal

cabloo commented 7 years ago

Hi Pascal,

Starred :)

Your interpretation is correct - they do have to be manually updated in this repository but sometimes that's actually a good thing: users are guaranteed to have a version you have tested alongside this application. When you upgrade this application to work with PHP7/PHP-Parser 2.0, you will just need to update the git submodule instead of instructing people to update their parser version. Also, it's very easy to switch from submodules to symlinks, but it's not easy to go the other way.

git@github must be a linux-only thing - it can be changed to https://github...

I thought of doing this because I created a repository specifically for the task of obfuscating an app I'm building. So I used this as a git submodule of my repository. Then I had to adjust my script to go into this software and set it up. When I changed to using a git submodule in this repository, I only had to do one git clone --recursive of the obfuscation repository and it then got this repo and the PHP-Parser repo with one command (no setup script required).