pk-hack / CoilSnake

https://pk-hack.github.io/CoilSnake/
GNU General Public License v3.0
158 stars 37 forks source link

MapEventModule: fix bank calculation #284

Closed PhoenixBound closed 5 months ago

PhoenixBound commented 6 months ago

Calculation of the bank is not as simple as adding C0, because 48 Mbit ROMs exist! And they put file addresses 40XXXX at 40XXXX in the address space, apparently. (Definitely not 101XXXX. That's not a valid SNES address.) Defer to CoilSnake's existing address translation logic instead of the + 0xC0.

Messianic reported running into this issue. Until he gets a chance to test the fix for the compilation phase, I'm marking this as a draft.