search

pk-nb / react-delegate-component

A component that makes renderProps great, allowing callers to use functional and class components with a default.
https://www.npmjs.com/package/react-delegate-component
3 stars 1 forks source link

componentWillReceiveProps #1

Open mhuggins opened 5 years ago

mhuggins commented 5 years ago

Hey, buddy! I see this package uses componentWillReceiveProps. Since this will be deprecated in React 17, would it be better to remove this lifecycle method from the package, or would you recommend using react-lifecycles-compat to polyfill? Happy to submit a PR if it helps! 😄

pk-nb commented 5 years ago

Hey @mhuggins! Yeah it's been on my list for a bit (along with typescript)! I can get to it this weekend but feel free to submit a PR if you have it ready to go!

pk-nb commented 5 years ago

I would probably just cut a new major version with new lifecycles at this point.