Closed acinader closed 5 years ago
this is awesome @acinader thanks.
couple of questions:
Hi @pkallos
I did test! you can see the test output in this PR's description. It looks good to me, but I don't have before and after that I could compare. i.e. I don't have records from the current version.
I didn't test it as a module cause I don't have an active project that I am using this in! If someone does they could do a good before after test by using this branch in their package.json. Having said that, I don't think that it'll improve anything with my eyes, cause I still won't have before and after.
We can choose the squash the commits option when we press the merge button.
awesome looks great, will cut another version
Don't set winston as a peer dependency. npm 6 doesn't have any kind of support for peer dependencies (yet) and if you install the dependency for testing then it adds it to the package. Not sure about this one....TODO: test it with an actual, you know, aws firehose.meh, looks like it works to me. here's what was in my s3 bucket:
👍 :tractor:
Fixes: #14