search

pkaminski / digest-hud

Digest performance analysis HUD for AngularJS.
MIT License
111 stars 20 forks source link

Compatible with both underscore and lodash #5

Closed mstrutt closed 9 years ago

mstrutt commented 9 years ago

First up, really nice little tool, thanks for making it! Has been really useful in speeding up the project I've been working on.

Basically we use lodash instead of underscore and I ran into an issue when I used this with the latest version. I appreciate that you specifically say it's for use with underscore, but as it's just a one-liner to work with both I though it would be worth doing.

.take is an alias of .first in underscore, but in lodash .first is explicitly the first item, and .take is the first x items.

What do you think, worth a merge to maximise compatibility? :)

pkaminski commented 9 years ago

Sure, sounds good. Wanna update the README as well to indicate that it'll also work with lodash now? Thanks!

mstrutt commented 9 years ago

Good idea, have done that now :)

pkaminski commented 9 years ago

Thanks, merged!

Sarkie commented 9 years ago

@pkaminski should you update the bower version? (don't know)

pkaminski commented 9 years ago

Yeah, I probably should. Done.

On Wed, Jun 3, 2015 at 4:36 AM, Sarkie notifications@github.com wrote:

@pkaminski https://github.com/pkaminski should you update the bower version? (don't know)

— Reply to this email directly or view it on GitHub https://github.com/pkaminski/digest-hud/pull/5#issuecomment-108321881.

Piotr Kaminski piotr@ideanest.com "That bun is dirty. Don't eat that bun."