Peer dependency warning

pke / eslint-plugin-redux-saga

ESLint rules for redux-saga

MIT License

135 stars 16 forks source link

Peer dependency warning #53

Closed ahce closed 5 years ago

ahce commented 5 years ago

Expected behavior

No peer warn

Actual behavior

npm WARN eslint-plugin-redux-saga@0.10.0 requires a peer of redux-saga@>= 0.11.1 < 1 || 1.0.0-beta.3 but none is installed. You must install peer dependencies yourself.

Steps to reproduce

npm install --save redux-saga@1.0.0

Environment

Tech	Version
redux-saga	1.0.0
eslint-plugin-redux-saga	0.10.0

pke commented 5 years ago

Yes the peer-dependency is too strict. A patch should be easy to set the version to a less restrictive one. I'll do that later.

ahce commented 5 years ago

@pke please, remember this

pke commented 5 years ago

On my radar.

pke commented 5 years ago

Closed by #54 Thanks to @amercier

pke commented 5 years ago

And released as 1.0.0 (to match redux-saga ;)