pkg / browser

Package browser provides helpers to open files, readers, and urls in a browser window.
BSD 2-Clause "Simplified" License
559 stars 99 forks source link

Don't use `sensible-browser` directly (linux) #3

Closed jvatic closed 8 years ago

jvatic commented 8 years ago

sensible-browser blocks the current process and doesn't open the expected browser (using system vs user default).

xdg-open is non-blocking, uses the user default browser, and falls back to using sensible-browser.

See https://github.com/flynn/flynn/issues/2125#issuecomment-156953583

davecheney commented 8 years ago

LGTM. Silly me for assuming sensible-browser would do something sensible.

jvatic commented 8 years ago

Thanks! :)