Rename Diffable to Interface?

pkg / diff

BSD 3-Clause "New" or "Revised" License

88 stars 9 forks source link

Rename Diffable to Interface? #3

Closed mvdan closed 5 years ago

mvdan commented 6 years ago

We have sort.Interface in the standard library. Why go for diff.Diffable instead of diff.Interface? The former seems to stutter a bit.

On the other hand, we already have two interfaces here, while package sort only has the one.

josharian commented 5 years ago

Agreed on the stutter. I've personally never really liked sort.Interface, although there is value in consistency. As an effort to find something better, what do you think about...diff.AB? diff.Comparable? diff.Pair? diff.Input?

mvdan commented 5 years ago

I like diff.Pair :)